NUT-23: add per-quote description hashes - #417
Open
sotach1 wants to merge 1 commit into
Open
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
description_hashboolean to BOLT11 mint quote requestsh = SHA256(UTF8(description))behaviordbehavior when the option is omitted or falseoptions.description_hashMotivation
Some protocols provide the invoice description out of band and require the BOLT11 invoice to commit to its exact bytes. NIP-57 zap requests are one example. A mint-wide setting would regress ordinary Cashu deposit memos, so the choice needs to be made independently for each quote.
Reference implementation: cashubtc/nutshell#1105
Client integration: candypoets/lnuts#1