fix(core): make memory transactions rollback-safe - #429
Draft
Egge21M wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 53dd6b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 93.40% 93.43% +0.03%
==========================================
Files 113 113
Lines 17930 18059 +129
==========================================
+ Hits 16748 16874 +126
- Misses 1182 1185 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cashu/coco-coreProblem
MemoryRepositories.withTransactionpreviously invoked the callback directly, so a thrown callback could leave partial durable state behind. A snapshot-only implementation would also risk rolling back unrelated root writes made while a transaction was active.This pull request resolves #422.
Scope
This is limited to rollback-safe in-memory transactions and regression tests. It does not introduce a Batch Mint Operation model, repository, public API, migration, or runtime behavior.
Verification
bun run --filter='@cashu/coco-core' test -- test/unit/MemoryRepositories.test.tsbun run --filter='@cashu/coco-core' test:unit— 1,245 passedbun run --filter='@cashu/coco-core' buildbun run --filter='@cashu/coco-core' typecheckgit diff --checkChangeset
.changeset/safe-memory-transactions.md