Attrs rewrite#50
Open
carolynzech wants to merge 6 commits into
Open
Conversation
added 3 commits
June 26, 2025 13:36
the attribute lifetime is tied to TyCtxt, so we should make that explicit
carolynzech
force-pushed
the
attrs-rewrite
branch
2 times, most recently
from
0259485 to
f331616
Compare
added 2 commits
July 26, 2025 18:38
…ct_attribute` to call `resolve_fn_path` and thereby be able to resolve qualified paths, which they can't do in the current impl because `resolve_from_mod` only handled simple paths
carolynzech
force-pushed
the
attrs-rewrite
branch
from
f331616 to
5c6f2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #ISSUE-NUMBER
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.