Repository navigation
Conversation
The sync operator integration test restricts splitwell to permissioned participants the way the LocalNet bootstrap does, permissioning the connected participant first. A participant outside that set is refused, and joins once the owner permissions it. Splitwell is opened again at the end, since the other tests in the job share its Canton. Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
A full connect pushes the participant's own topology, which needs traffic on the zero-base-rate splitwell, so the joins run only the onboarding handshake and are read from the owner's topology. The test also checks that a participant joins without a permission while onboarding is open. Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
sadiq1971
marked this pull request as ready for review
October 6, 2026 13:56
| syncOperatorBackend.appState.store.key.synchronizerId shouldBe served | ||
| } | ||
|
|
||
| "admit participants as its onboarding restriction allows" in { implicit env => |
There was a problem hiding this comment.
which code is that testing? it seems to me like you are just testing the underlying canton functionality instead of the dsync specific code. Is that right? If so, that should already be tested in the Canton repository.
Collaborator
Author
There was a problem hiding this comment.
It's from one of the user stories - With restriction open a participant can be connected to the dsync.
I will check if the test scenario already covered
Collaborator
Author
There was a problem hiding this comment.
Looks the the test already exist - So it will close the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ChainSafe/canton-extending-mainnet#127
Summary: the sync operator integration test checks splitwell's onboarding restriction both ways: while open, a participant joins without a permission; while restricted, one without a permission is refused and one the owner permissions joins. The operator write-up comes separately.