Skip to content

test: check the discount and an unregistered buy - #64

Merged
sadiq1971 merged 4 commits into
mainfrom
test/localnet-discount-and-unregistered-buy
Oct 3, 2026
Merged

sadiq1971 merged 4 commits into
mainfrom
test/localnet-discount-and-unregistered-buy

Conversation

@sadiq1971

@sadiq1971 sadiq1971 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Closes ChainSafe/canton-extending-mainnet#137

Summary: the sync operator integration test registers the synchronizer at a 0.5 discount, checks the purchase costs half the global synchronizer's price, and checks that a buy for an unregistered synchronizer is refused.

Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
@sadiq1971 sadiq1971 self-assigned this Sep 30, 2026
@sadiq1971
sadiq1971 marked this pull request as ready for review September 30, 2026 14:59

@moritzkiefer-da moritzkiefer-da left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the other comment, let's test that as part of the normal integration test not localnet.

…n test [ci]

Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
@sadiq1971 sadiq1971 changed the title test: check the discount and an unregistered buy on LocalNet test: check the discount and an unregistered buy Sep 30, 2026
@sadiq1971

Copy link
Copy Markdown
Collaborator Author

similar to the other comment, let's test that as part of the normal integration test not localnet.

done

@moritzkiefer-da moritzkiefer-da left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to integration test this? doesn't the daml script test already give us the right coverage here? Or do you see backend logic that matter for this?

@sadiq1971

Copy link
Copy Markdown
Collaborator Author

why do we need to integration test this? doesn't the daml script test already give us the right coverage here? Or do you see backend logic that matter for this?

From the user story I wanted to cover all the cases in the integration tests. I can drop this if it is not required.

@moritzkiefer-da moritzkiefer-da left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx seems simple enough that I don't mind the integration test here.

Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
@sadiq1971
sadiq1971 merged commit 5e8e4c8 into main Oct 3, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2-E9.9] LocalNet test: register at a discount, refuse an unregistered buy

2 participants