fix(store): protect Version() with mutex to prevent race condition - #597
Open
yasinlex wants to merge 1 commit into
Open
fix(store): protect Version() with mutex to prevent race condition#597yasinlex wants to merge 1 commit into
yasinlex wants to merge 1 commit into
Conversation
The Version() method previously accessed s.version without any synchronization, while Commit() updates s.version while holding the mutex. This could lead to race conditions when Version() is called from RPC handlers or other goroutines while Commit() is in progress. Now Version() acquires the mutex before reading s.version, ensuring thread-safe access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Version()accesseds.versionwithout synchronization:While
Commit()updatess.versionwhile holding the mutex:This creates a race condition when
Version()is called from:While
Commit()is updating the version.Fix
Impact