fix(bft): return error when committee loading fails - #596
Open
yasinlex wants to merge 1 commit into
Open
Conversation
Previously, errors from LoadCommittee() and LoadCommitteeData() were only logged as warnings, allowing the BFT to continue with a potentially nil validator set. This could lead to panics when the validator set is used later. Now returns from Start() on committee loading failures, preventing the BFT from running with an invalid state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
bft/bft.goStart()function, errors fromLoadCommittee()andLoadCommitteeData()were only logged as warnings:This allowed the BFT to continue with a potentially nil validator set, which would cause panics when:
GetValidator()is called (line 242)SendToReplicas()is called (lines 270, 346, 446, etc.)SelectProposerFromCandidates()is called (line 291)Fix
Changed from logging warnings to returning errors:
Impact