chore: remove provisioningserver dead code - #642
Merged
alemar99 merged 1 commit intoSep 15, 2026
Merged
Conversation
There was a problem hiding this comment.
[maas-code-reviewer review]
LLM-generated review from https://github.com/canonical/maas-code-reviewer.
Intended to assist a human reviewer, not replace one — suggestions may be
incorrect, please verify before acting.
Removing these files (src/provisioningserver/auth.py and src/provisioningserver/concurrency.py) looks good assuming their contents are obsolete or have been refactored elsewhere. Please double-check that any remaining imports of provisioningserver.auth (like get_maas_user_gpghome or API_CREDENTIALS_CACHE_KEY) and provisioningserver.concurrency (like the dhcpv4 and dhcpv6 DeferredLocks) have been cleared out from the rest of the codebase to avoid ImportErrors.
alexsander-souza
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.