-
Notifications
You must be signed in to change notification settings - Fork 42
feat: unified config file support for Expo #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artus9033
wants to merge
15
commits into
main
Choose a base branch
from
feat/config-file-expo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6160bf2
docs: document setup for schema json in IDEs
artus9033 f6fa946
fix: cli to dev-depend on prettier to make binary available to scripts
artus9033 c977406
feat: add missing schema typings comments
artus9033 3de0a27
feat: drop obsolete options from config file
artus9033 06d1752
chore: bump up Rock to downstream descriptions for schema
artus9033 4794f54
feat: support brownfield unified config file in Expo
artus9033 aad2cc3
refactor: loadBrownfieldConfig to return null when no config file exists
artus9033 9f07249
Merge branch 'main' into feat/config-file-expo
artus9033 155e2be
fix(docs): obsolete, old config file name
artus9033 b454b4d
fix: handling of edge cases
artus9033 d4913df
fix: allow union types in Ajv when parsing the config schema
artus9033 81f3ee0
chore: migrate ExpoApp55 demo app to the brownfield config file workflow
artus9033 9737a74
fix: ensure Expo prebuild failing with cryptic error under conflict o…
artus9033 e9df539
test: adjust tests
artus9033 4ce193e
fix(docs): invalid package.json key name in docs
artus9033 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@callstack/react-native-brownfield': patch | ||
| '@callstack/brownfield-cli': patch | ||
| --- | ||
|
|
||
| feat: support brownfield unified config file in Expo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@callstack/brownfield-cli': patch | ||
| --- | ||
|
|
||
| fix: generate config schema with descriptions, add more descriptions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.