Repository navigation
Fix PHP 8.6 install and phive rate limit in shared workflows - #30
Merged
Merged
Conversation
The PHP 8.6 jobs failed in composer before any test ran, because dependencies such as laminas-diactoros do not allow 8.6 in their PHP constraint yet. Ignore the upper bound of the PHP requirement there. phive queried the GitHub releases API anonymously and ran into the rate limit with a 403. Pass the workflow token so the request is authenticated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failures that hit every repo using these workflows, seen on cakephp/bake#1111.
PHP 8.6 job: composer fails before any test runs, because dependencies such as
laminas-diactorosdo not allow 8.6 in their PHP constraint yet. The 8.6 entries now pass--ignore-platform-req=php+, which only lifts the upper bound.phive:
phive installqueried the GitHub releases API anonymously and got a 403 from the rate limit. The step now receives the workflow token asGITHUB_AUTH_TOKEN.A bake run against this branch is green on all jobs, including 8.6: https://github.com/cakephp/bake/actions/runs/37660803108