Refactor Coin Control - #3617
Draft
malik1004x wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
The Coin Control feature suffered from numerous issues in recent time stemming from desynced, duplicated state or persisting information that should have never been persisted. This PR refactors the feature to minimize duplicated state across the feature as well as remove the dependency on MobX and Hive.
UnspentInfoHive Box has been completely removed. Its only two rows that were actually required to be persistent for this feature - the coin freeze status and the coin notes - were placed in SQLite tables.CoinSelectionobject tocreateTransaction. This means there is no chance of the coin selection persisting across transaction creations (previously, the coin selection was explicitly reset when pressing "Send" on the Home page).getCoinis an expensive operation, and calling it every time the freeze status was checked could cause lag).Pull Request - Checklist