logging: close file handle on permission errors when not rolling (#7833)#7838
Open
vvdvortsova wants to merge 1 commit into
Open
logging: close file handle on permission errors when not rolling (#7833)#7838vvdvortsova wants to merge 1 commit into
vvdvortsova wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a native English speaker, so I used AI to help translate this PR description. The code and analysis are my own.
Fix resource leak in
OpenWriter.Fix for issue #7833.
What
In
FileWriter.OpenWriter(modules/logging/filewriter.go), whenroll: falseand a custommodeis configured, the function could return early (on aStatorChmoderror) without ever closing the previously openedfile, leaking the descriptor. Addedfile.Close()on both error-return paths inside that block. The success path (returning the open file handle to the caller when!roll) is left untouched, since that handle is intentionally returned open to the caller.Testing
go build ./modules/logging/...go vet ./modules/logging/...