Skip to content

Improve API definitions #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlattimore merged 6 commits into from
May 13, 2026
Merged

Improve API definitions #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0239e46
Remove unused unsafe permissions
XSpielinbox May 13, 2026
a35e7fb
Add std::os::darwin::fs to fs API
XSpielinbox May 3, 2026
64aa828
Add std::os::linux::net to net API
XSpielinbox May 3, 2026
fb1e0c7
Add std::os::linux::process to process API
XSpielinbox May 3, 2026
7485455
Remove nonexistent std::os::wasi::net from net API
XSpielinbox May 3, 2026
7bf7a58
Comment out unsupported platform specific APIs
XSpielinbox May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions cackle.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ allow_proc_macro = true
allow_unsafe = true

[pkg.serde]
allow_unsafe = true
allow_apis = [
"fs",
]
Expand Down Expand Up @@ -198,9 +197,6 @@ build.allow_apis = [
[pkg.twox-hash]
allow_unsafe = true

[pkg.stable_deref_trait]
allow_unsafe = true

[pkg.winnow]
allow_unsafe = true

Expand All @@ -222,18 +218,12 @@ allow_unsafe = true
[pkg.ruzstd]
allow_unsafe = true

[pkg.toml_edit]
allow_unsafe = true

[pkg.memchr]
allow_unsafe = true

[pkg.once_cell]
allow_unsafe = true

[pkg.addr2line]
allow_unsafe = true

[pkg.object]
allow_unsafe = true
build.allow_apis = [
Expand All @@ -257,7 +247,6 @@ test.sandbox.make_writable = [
"test_crates/custom_target_dir",
]
test.sandbox.allow_network = true
test.allow_unsafe = true

[pkg.clap_builder]
allow_apis = [
Expand Down
23 changes: 17 additions & 6 deletions src/config/built_in.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ pub(crate) fn get_built_ins() -> BTreeMap<ApiName, ApiConfig> {
perm(
&[
"std::fs",
// Darwin is not yet supported
//"std::os::darwin::fs",
"std::os::linux::fs",
"std::os::unix::fs",
"std::os::unix::io",
"std::os::wasi::fs",
"std::os::wasi::io",
"std::os::windows::fs",
"std::os::windows::io",
// WASI is not yet supported
//"std::os::wasi::fs",
//"std::os::wasi::io",
// Windows is not yet supported
//"std::os::windows::fs",
//"std::os::windows::io",
"std::path",
Comment thread
XSpielinbox marked this conversation as resolved.
],
&[],
Expand All @@ -26,7 +30,12 @@ pub(crate) fn get_built_ins() -> BTreeMap<ApiName, ApiConfig> {
result.insert(
ApiName::from("net"),
perm(
&["std::net", "std::os::wasi::net", "std::os::windows::net"],
&[
"std::net",
"std::os::linux::net",
// Windows is not yet supported
//"std::os::windows::net",
],
&[],
),
);
Expand All @@ -39,8 +48,10 @@ pub(crate) fn get_built_ins() -> BTreeMap<ApiName, ApiConfig> {
perm(
&[
"std::process",
"std::os::linux::process",
"std::unix::process",
"std::windows::process",
// Windows is not yet supported
//"std::windows::process",
],
&["std::process::abort", "std::process::exit"],
),
Expand Down