This repository was archived by the owner on Nov 9, 2026. It is now read-only.
Repository navigation
fix: preserve text literals in generated typing commands - #257
Open
Ricardo-M-L wants to merge 1 commit into
Open
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated
typescripts currently embed text between single quotes after escaping only apostrophes. Windows paths and backslash sequences are interpreted as Python escapes, while embedded newlines or a trailing backslash can produce an invalid script. Usereprfor the text argument in both clipboard and direct-typing code paths so the executed script receives the original text.This does not change terminal-newline detection/trimming. The independent
rstripissue is already covered by #248; this PR does not duplicate or close that work. Coordinate parsing, hotkeys and other action types are unchanged.Validation
pyautogui, clipboard and clock stubs. The four failing groups on the original implementation cover Windows paths, apostrophe-plus-backslash text, embedded newlines and a trailing backslash, in both typing modes. Plain text, Unicode and the existing Enter behavior are controls.uv buildproduces the sdist and wheel; new-test Ruff/format andgit diff --checkpass. No real keyboard/mouse/clipboard interaction or model call is made.uv sync --lockedreports pre-existing lock/metadata drift.uv sync --frozeninstalls the committed lock successfully; neither dependencies nor the lockfile were changed.AI-assisted source audit, implementation and repeated offline validation with OpenAI Codex. No live GUI/model evaluation, human approval or hosted CI success is claimed.