fix: carry draft attachments in the Pro draft tab too - #877
Merged
rathlinus merged 1 commit intoAug 25, 2026
Conversation
The bulwarkmail#849 fix carries a re-opened draft's parts into the composer on the classic path, but the Pro draft tab builds its own initialData and still omitted email.attachments - editing a draft from a Pro tab kept stripping its files on the next save. Pass the parts through; the composer's existing initializer and remap handle the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5d2b937 fixed #849 for the classic draft path: a re-opened draft carries its already-uploaded parts into the composer. The Pro draft tab builds its own
initialDataand still omitsemail.attachments— editing a draft from a Pro tab keeps opening the composer without its files, and the next save strips them from the stored draft.Changes
email.attachmentsthrough the Pro draft tab'sinitialData; the composer's existing initializer, blob-id remap and dirty-check from 5d2b937 handle everything else.Related issues
Related to #849 (closes the remaining Pro-mode gap of that fix).
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / demo
No new UI — the Pro draft tab simply shows the draft's attachment chips again, like the classic path does since 5d2b937.
Notes for reviewers
npm run typecheck,npm run lint,npm run buildand the fullnpx vitest run.