fix .bridge file loading by encoding brackets using toURI().toString() - #260
Open
traybug23 wants to merge 2 commits into
Open
fix .bridge file loading by encoding brackets using toURI().toString()#260traybug23 wants to merge 2 commits into
traybug23 wants to merge 2 commits into
Conversation
egonw
requested changes
Mar 25, 2026
egonw
self-requested a review
June 24, 2026 12:13
Member
@traybug23, I am sorry that it took so long. But I cannot put this in the first next release yet, as I do not have enough time right now to create a new PathVisio version. How did you test this? Did you recompile PathVisio with the new jars? When I use the below test code, I see that the two approaches are not equivalent, and I am afraid that the addition of file = new File("pom (1).xml")
println file
println file.getAbsolutePath()
println file.toURI().toString() |
egonw
reviewed
Aug 2, 2026
egonw
left a comment
Member
There was a problem hiding this comment.
See other reply just a few seconds ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BridgeDb loading issues #211
The issue was that when a .bridge file was being downloaded twice, Windows would automatically add (1) to the file name and the plugin was unable to load it.
Solution: .toURI().toString(); encodes the parantheses from special character to %28 and %29. This would also encode (space) in the file name as %20, thus in case a file would have space in its name, it will still be loaded.
( is encoded as %28
) is encoded as %29
(space) is encoded as %20
Now, the BridgeDb files can load successfully.
@egonw @DeniseSl22