Refactor leveragers inheritance chains#1064
Draft
wadimw wants to merge 2 commits into
Draft
Conversation
Removed code relevant only for target leveraging (overwrite mode checks). Folded the inherited class chain into a single SourceLeverager to better encapsulate its logic.
Deleted AbstractLeverager and its test. Extracted shared operations (addLeveragedTranslations, filterTextUnitDTOWithSameTMTextUnitId, TextUnitSearcher access) into a LeveragingUtils component. LeveragerByTmTextUnit and LeveragerByContentAndRepository no longer inherit from the same base class. SourceLeverager delegates to LeveragingUtils instead of duplicating the translation-writing logic.
wadimw
added
the
upstream-patched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the AbstractLeverager subclasses chaning in favour of self-contained
SourceLeveragerand others, to matchCopyTmLeveragerimplementation from #1063.This PR shouldn't affect leveraging behaviour - it's only for refactor/cleanup (to avoid assymetry between
CopyTmLeveragerand others).TODO run AI code review