Update BOUT++ - #632
Closed
dschwoerer wants to merge 59 commits into
Closed
Conversation
Modify Div_par_fvv and Div_par_fvv_heating so that they compile with 3D metrics.
Dataset.hermes.extract_[12]_tokamak_geometry() calls now result in an
error:
```
Traceback (most recent call last):
File "/home/runner/work/hermes-3/hermes-3/build/tests/integrated/2D-recycling/runtest", line 144, in <module>
ds = ds.hermes.extract_2d_tokamak_geometry()
File "/home/runner/.local/lib/python3.10/site-packages/xhermes/accessors.py", line 172, in extract_2d_tokamak_geometry
raise Exception(
Exception: extract_2d_tokamak_geometry was called twice! Note: this is now done automatically upon loading
```
… compile-3dmetric-clean
…ile-3dmetric-clean
The interpolation method for the cell faces was modified, resulting in slightly different results.
Fixups for compiling with 3D metrics
Thanks @ZedThree for the suggestions
… compile-3dmetric
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 57.53% 57.82% +0.28%
==========================================
Files 98 97 -1
Lines 10223 10036 -187
Branches 1466 1443 -23
==========================================
- Hits 5882 5803 -79
+ Misses 3753 3652 -101
+ Partials 588 581 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bendudson
approved these changes
Aug 8, 2026
bendudson
left a comment
bendudson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @dschwoerer ! I think this replaces #577 (?)
Collaborator
Author
|
I thought this could be a follow up on #577, but I think I need this already in #577, to get boutproject/BOUT-dev#3452 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make most recent changes of BOUT++ available in Hermes-3
Change Summary
See Upstream
Validation
Upstream CI / CI here
AI Assistance
None
Documentation
None
Review Notes
Includes #577