Use Field3DParallel if we need parallel fields - #3453
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Field3D Div_par(const Field3D& f, const Field3D& v) { | ||
| Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { |
There was a problem hiding this comment.
warning: function 'Div_par' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
| Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { | |
| static Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { |
There was a problem hiding this comment.
I fail to see why this function is hidden, but if it really is not exposed, we should probably delete it instead.
There was a problem hiding this comment.
It doesn't appear to be used anywhere and it's not exposed in the header -> delete
There was a problem hiding this comment.
Perhaps it should be added to the header? It has a different signature from other Div_par implementations.
There was a problem hiding this comment.
I messed up the signature in header. It does not seem to be used anywhere, so maybe we should deprecate it, if no one is using it?
3 participants
With #3430 this makes Div_par just work in many cases for FCI.