Skip to content

Migrate timestamps to consistently use BUILD_ID_TIMESTAMP - #754

Merged
jmt-lab merged 7 commits into
bottlerocket-os:developfrom
jmt-lab:push-lynxlrypplro
Oct 7, 2026
Merged

jmt-lab merged 7 commits into
bottlerocket-os:developfrom
jmt-lab:push-lynxlrypplro

Conversation

@jmt-lab

@jmt-lab jmt-lab commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes:
This PR changes multiple metadata points in twoliter that use a timestamp in a production build artifact. Previously we would record the time twoliter was run to build the image, kit etc. This makes builds unreproducible by nature of a constantly changing timestamp. Instead this PR brings in BUILD_ID_TIMESTAMP and uses the timestamp of the commit being built.

Testing done:

  • Built kernel kit and verified mtimes and BUILDTIME are set to BUILD_ID commit sha timeline
  • Checked oci artifact from kernel kit all dates line with buildtime

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jmt-lab
jmt-lab marked this pull request as ready for review September 25, 2026 23:42
@jmt-lab
jmt-lab marked this pull request as draft September 25, 2026 23:43
@jmt-lab
jmt-lab marked this pull request as ready for review September 25, 2026 23:55
Comment thread twoliter/embedded/build.Dockerfile Outdated
@jmt-lab
jmt-lab force-pushed the push-lynxlrypplro branch from 2f9dfcc to dd85d59 Compare October 7, 2026 19:23
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
…rball

Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
@jmt-lab
jmt-lab force-pushed the push-lynxlrypplro branch from dd85d59 to ba161bd Compare October 7, 2026 19:30
@jmt-lab
jmt-lab merged commit 9c1b67c into bottlerocket-os:develop Oct 7, 2026
3 checks passed
@jmt-lab
jmt-lab deleted the push-lynxlrypplro branch October 7, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants