Repository navigation
Migrate timestamps to consistently use BUILD_ID_TIMESTAMP - #754
Merged
Merged
Conversation
jmt-lab
force-pushed
the
push-lynxlrypplro
branch
from
September 25, 2026 23:38
e407907 to
a009ce7
Compare
jmt-lab
marked this pull request as ready for review
September 25, 2026 23:42
jmt-lab
marked this pull request as draft
September 25, 2026 23:43
jmt-lab
force-pushed
the
push-lynxlrypplro
branch
from
September 25, 2026 23:55
a009ce7 to
2f9dfcc
Compare
jmt-lab
marked this pull request as ready for review
September 25, 2026 23:55
qianxjcraig
approved these changes
Oct 1, 2026
sam-berning
reviewed
Oct 1, 2026
jmt-lab
force-pushed
the
push-lynxlrypplro
branch
from
October 7, 2026 19:23
2f9dfcc to
dd85d59
Compare
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
…rball Signed-off-by: Jarrett Tierney <jmt@amazon.com>
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
jmt-lab
force-pushed
the
push-lynxlrypplro
branch
from
October 7, 2026 19:30
dd85d59 to
ba161bd
Compare
sam-berning
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR changes multiple metadata points in twoliter that use a timestamp in a production build artifact. Previously we would record the time twoliter was run to build the image, kit etc. This makes builds unreproducible by nature of a constantly changing timestamp. Instead this PR brings in BUILD_ID_TIMESTAMP and uses the timestamp of the commit being built.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.