Conversation
dellaert
reviewed
Jul 26, 2026
dellaert
left a comment
dellaert
left a comment
Member
There was a problem hiding this comment.
Very nice! But whenever you make a notebook, you can actually delete the corresponding python file. We don’t want to keep both.
Also, several intro statements referred to “so far”, implying a sequence of reading the notebooks, but there really is no sequence. So maybe edit those intro comment slightly.
Delete the .py scripts that now have notebook counterparts (GPSFactorExample, OdometryExample, SimpleRotation, FixedLagSmootherExample, VisualISAMExample, DogLegOptimizerExample, SelfCalibrationExample, SFMExample) so the notebook is the single copy, per review feedback. Also reword intro/explanatory cells that referred to "so far", "previous notebook", or "earlier notebooks" -- these notebooks have no required reading order, so cross-references now name the other notebook directly instead of implying a sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the original GPSFactorExample.py script and checked values matched.
Ran the original OdometryExample.py script and compared outputs.
Ran the original SimpleRotation.py script and compared outputs.
Ran the original FixedLagSmootherExample.py script and compared outputs.
Ran the original VisualISAMExample.py script and compared outputs.
Ran the original DogLegOptimizerExample.py script and compared success-rate trends (uses unseeded random sampling, so exact numbers vary run to run).
Ran the original SelfCalibrationExample.py script and checked values matched.
Ran the original SFMExample.py script and compared convergence behavior (uses unseeded random sampling, so exact numbers vary run to run).
Deleted original .py files