Skip to content

Allow dry-run when testing new prune-settings #88

Closed
Closed
Allow dry-run when testing new prune-settings#88
Labels
help wantedThis issue is available, comment if you want to fix ittype:enhancementImprovement of an existing function

Description

@schwma
schwma
opened on Dec 9, 2018

It would be great to be able to specify your own templates for archive names, just like when using borg backup from the CLI. For example:

$ borg create /path/to/repo::{hostname}-{user}-{now} ~.
$ borg create /path/to/repo::{hostname}-{user}-{now:%Y-%m-%dT%H:%M:%S.%f} ~

Activity

  1. m3nu
    self-assigned this
    on Dec 10, 2018
  2. m3nu
    added
    type:enhancementImprovement of an existing function
    on Dec 10, 2018

  3. m3nu commented on Dec 10, 2018

    @m3nu
    m3nu
    on Dec 10, 2018
    Contributor

    Sure. We had long discussions on which archive name to use. Now that was all in vain... :-)

  4. m3nu
    added this to the v0.6.z Branch milestone on Dec 10, 2018

  5. ThomasWaldmann commented on Dec 10, 2018

    @ThomasWaldmann
    ThomasWaldmann
    on Dec 10, 2018
    Collaborator

    not in vain, it can be used as the default value still.

    when making this adjustable, there needs to be also flexible prune prefix and maybe some sanity check, so people do not accidentally prune away lots of stuff.

  6. m3nu commented on Dec 11, 2018

    @m3nu
    m3nu
    on Dec 11, 2018
    Contributor

    Here what I got so far. There is a preview and it won't save unless the formatting works.

    Still thinking about the sanity check to avoid excessive pruning..

    screenshot 2018-12-11 at 23 15 18

  7. m3nu commented on Dec 11, 2018

    @m3nu
    m3nu
    on Dec 11, 2018
    Contributor

    Left to do:

    • Actually use new settings for pruning and creating archives.
    • Sanity check if possible
    • Test

  8. ThomasWaldmann commented on Dec 11, 2018

    @ThomasWaldmann
    ThomasWaldmann
    on Dec 11, 2018
    Collaborator

    For borg cli, the sanity check is by the user reading the output of borg prune --dry-run.

  9. m3nu commented on Dec 14, 2018

    @m3nu
    m3nu
    on Dec 14, 2018
    Contributor

    I ended up moving those 2 options to the Archives tab and putting the other pruning options in a separate section. Made more sense to keep them together. I'd also prefer to set new archive names per-profile instead of globally.

    Will merge this as 0.6.1 (pre-release) soon, since there are 2 other bugs I'd like to see corrected. If you can think of any changes to improve this feature, let me know.

  10. m3nu commented on Dec 14, 2018

    @m3nu
    m3nu
    on Dec 14, 2018
    Contributor

    screenshot 2018-12-14 at 13 53 23

    Screenshot of new Prune Options section. Left to do:

    • Actually use new settings for pruning and creating archives.
    • Dry run and report on which repos would be pruned.
    • Test
  11. m3nu
    added a commit that references this issue on Dec 14, 2018

    v0.6.1 Release (#86)

    4f61372
  12. m3nu
    changed the title [-]Allow specifying of archive name templates[/-] [+]Allow dry-run when testing new prune-settings[/+] on Dec 14, 2018
  13. m3nu
    removed their assignment
    on Jan 20, 2019
  14. m3nu
    added
    help wantedThis issue is available, comment if you want to fix it
    on Jan 20, 2019
  15. m3nu
    removed this from the v0.6.z Branch milestone on Mar 6, 2019
  16. m3nu
    closed this as completedon Feb 15, 2021
  17. borgbase
    locked and limited conversation to collaborators on Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedThis issue is available, comment if you want to fix ittype:enhancementImprovement of an existing function

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions