You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistencies in branch hop, file HighPerfCodeGen.md #4
The first tiled MLIR example of the matrix multiplication (in section Tiling in MLIR)
seems inconsistent:
the affine map names are not those used in the code
the affine map parameters are not consistent with the tiling described above,
or with the matrix sizes (2088x2048). I believe they should read:
#map7 = (d0) -> (d064)
#map8 = (d0) -> (2088,d064+64)
Comparing code and GFLOPS along the transformations of the tutorial has a
minor flaw - at first matrix A has size 2088x2048, but then it seems to change to
2048x2048 (in section Explicit Copying and Packing).
In any case, a hugely useful tutorial to me and my students - this is why I am
sending this erratum, so that it may help others.
If I had a wishlist of things that I missed:
a good reference for unroll-and-jam
a good reference on vectorization
a TODO list explaining what has to be programmed into the hop
branch of your fork of mlir to perform the tutorial.
Activity
ColdCodeCool commentedon May 23, 2022
is there any update?
[mlir][affine] Enforce each result type to match Reduction ops in af…
[lldb] Return unimplemented error from ScriptedProcessInterface::Crea…
Revert "[lldb][DWARFASTParserClang] Fetch constant value from variabl…
Revert "[Support]Look up in top-level subcommand as a fallback when l…
[sanitizer] Fix asserts in asan and tsan in pthread interceptors. (ll…
[lldb] Fix the flakey Concurrent tests on macOS (llvm#81710)
Revert "[Coro] [async] Disable inlining in async coroutine splitting (l…
[tsan] Fix running check-ubsan with COMPILER_RT_DEBUG=ON
Fix for codegen Crash in Clang when using locator omp_all_memory with…
[libclang] Always Dup in createRef(StringRef) (llvm#125020)
Revert "[libclang] Always Dup in createRef(StringRef)" (llvm#127076)
[clang-repl] fix error recovery while parsing completely fails (llvm#…
[mlir] Fix FunctionOpInterface impl for external func (llvm#124693)
[win/asan] GetInstructionSize: Detect `66 90` two-byte NOP at 32-bit …
Revert "[AArch64][SVE] Pair SVE fill/spill into LDP/STP with -msve-ve…
[lldb][Format] Display only the inlined frame name in backtraces if a…
[ASan] Prevent ASan/LSan deadlock by preloading modules before error …
Revert "[Clang][analyzer] replace Stmt* with ConstCFGElementRef in Sy…
[clang-repl] : Fix clang-repl crash with --cuda flag (llvm#136404)
[clang-repl] Fix destructor for interpreter for the cuda negation case (
[lldb] fix crash on FreeBSD/powerpc64le (llvm#138331)
[Driver] Reject -mcmodel=tiny on X86 (llvm#125643)
[lldb-dap] Initialise the call mutex before the progress_event_report…
[ASan/sanitizers] Make stack unwinding better on Windows. (llvm#180205)
[lldb] Reject an unusable memory-cache-line-size (llvm#219217)