[PW_SID:1153294] [v1,1/4] Bluetooth: btintel_pcie: remove duplicate BTINTEL_PCIE_MAGIC_NUM definition - #661
Open
BluezTestBot wants to merge 9 commits into
Open
[PW_SID:1153294] [v1,1/4] Bluetooth: btintel_pcie: remove duplicate BTINTEL_PCIE_MAGIC_NUM definition#661BluezTestBot wants to merge 9 commits into
BluezTestBot wants to merge 9 commits into
Conversation
This patch adds workflow files for ci: [sync.yml] - The workflow file for scheduled work - Sync the repo with upstream repo and rebase the workflow branch - Review the patches in the patchwork and creates the PR if needed [ci.yml] - The workflow file for CI tasks - Run CI tests when PR is created Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
This replaces the bzcafe action with bluez/action-ci so we can maintain everything in the github bluez organization Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This attempts to sync every 5 minutes instead of 30. Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
bluez/action-ci uses master as default branch for workflow which is incorrect for kernel Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The CI action now creates individual GitHub Check Runs per test, which requires 'checks: write' permission on the GITHUB_TOKEN. Also make the pull_request trigger types explicit to include 'reopened', allowing CI to be retriggered by closing and reopening a PR.
…nition Two identical definitions of BTINTEL_PCIE_MAGIC_NUM were present in btintel_pcie.c, one indented with spaces and one with a tab. Remove the space-indented duplicate and the surrounding blank lines. Kernel coding style requires tabs for indentation, so keep the tab-indented copy. No functional change. Assisted-by: Copilot:claude-opus-4.7 sparse Fixes: 6ed8304 ("Bluetooth: btintel_pcie: Setup buffers for firmware traces") Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
Newer Intel BT PCIe variants (Nova Lake SCP2 and PTL FMP2) require three independent DRAM debug (DBGC) buffer pools instead of the single pool used by the existing controllers. Add multi-DBGC (MDBGC) support by factoring the per-pool buffer allocation into a common helper and adding a setup path that allocates three pools using the new fragment context format. The context information is programmed with the MDBGC fragment when the device reports an MDBGC-capable variant, otherwise the existing single-pool DBGC path is used. Assisted-by: Copilot:claude-opus-4.7 sparse Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
Add ktime-based measurement around btintel_pcie_msix_gp1_handler() so the time taken to service the mailbox interrupt and acknowledge the FW can be observed via bt_dev_dbg. Drop the informational log emitted on every mailbox interrupt (it is noisy at bt_dev_info level and the same timestamp is now available through the new debug print) and collapse a couple of over-wrapped lines for readability. No functional change beyond the log verbosity adjustment. Assisted-by: Copilot:claude-opus-4.7 sparse Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
Replace the legacy TLV-based coredump with a unified INI-format dump that is compatible with the iwlwifi decoder tool, so a single decoder can parse coredumps across all Intel BT PCIe controller variants. The dump is emitted through dev_coredumpsg() as a scatter-gather list of structured regions built from the firmware-provided memory addresses parsed from the mailbox TLVs: - DRAM monitor buffers (single or multi-buffer per MDBGC support) - SMEM monitor region - Exception event buffer - DCCM, SDS, SDS IOSF and ECL memory regions - Dump info metadata (FW version, HW variant, trigger reason) Regions are collected only when the firmware advertises a valid address and size. Only the regions actually collected have their corresponding bit set in the dump-info regions_mask, so the decoder knows which region IDs to expect. The dump-info metadata is populated from the mailbox-advertised CNVi and CNVr registers using the following bit-field encoding, matching the iwlwifi decoder expectations: HwType = CNVi bits 11:0 HwStep = CNVi bits 27:24 RfIdType = CNVr bits 11:0 RfIdDash = CNVr bits 23:20 RfIdStep = CNVr bits 27:24 RfIdFlavor = CNVr bits 31:28 Two new extractor macros INTEL_CNVX_TOP_DASH() and INTEL_CNVX_TOP_FLAVOR() are added to btintel.h alongside the existing INTEL_CNVX_TOP_TYPE() and INTEL_CNVX_TOP_STEP() helpers, so the same shared bit definitions are reused for the HwType/HwStep and RfId* fields. Serialization of the dump path relies on existing infrastructure: the ordered dump_workqueue guarantees that any companion event reader (fwtrigger_work / hwexp_work) runs before coredump_work so dmp_hdr trigger metadata is fully populated when dump_info consumes it, and the BTINTEL_PCIE_COREDUMP_INPROGRESS bit acts as a single-writer guard against re-entrant triggers. Teardown drains all three works via disable_work_sync() before freeing the driver data. The unified format has no consumer for the legacy debug-trigger event type / event id fields, so drop the now-dead writes to dmp_hdr.event_type / event_id and remove those two members from struct btintel_pcie_dump_header. The values are still logged from the firmware event via bt_dev_dbg for debugging. Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
|
CheckPatch |
|
VerifyFixes |
|
VerifySignedoff |
|
GitLint |
|
SubjectPrefix |
|
BuildKernel |
|
CheckAllWarning |
|
CheckSparse |
|
BuildKernel32 |
|
CheckKernelLLVM |
|
TestRunnerSetup |
|
IncrementalBuild |
github-actions
Bot
force-pushed
the
workflow
branch
7 times, most recently
from
September 4, 2026 19:41
8f53a45 to
d690686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two identical definitions of BTINTEL_PCIE_MAGIC_NUM were present in
btintel_pcie.c, one indented with spaces and one with a tab. Remove the
space-indented duplicate and the surrounding blank lines. Kernel coding
style requires tabs for indentation, so keep the tab-indented copy.
No functional change.
Assisted-by: Copilot:claude-opus-4.7 sparse
Fixes: 6ed8304 ("Bluetooth: btintel_pcie: Setup buffers for firmware traces")
Signed-off-by: Chandrashekar Devegowda chandrashekar.devegowda@intel.com
drivers/bluetooth/btintel_pcie.c | 5 -----
1 file changed, 5 deletions(-)