Skip to content

Fix mavlink endpoints page in mobile and access via proxy - #4401

Merged
joaoantoniocardoso merged 3 commits into
bluerobotics:masterfrom
patrickelectric:fix-mobile-endpoints
Sep 4, 2026
Merged

Fix mavlink endpoints page in mobile and access via proxy#4401
joaoantoniocardoso merged 3 commits into
bluerobotics:masterfrom
patrickelectric:fix-mobile-endpoints

Conversation

@patrickelectric

Copy link
Copy Markdown
Member

Helps #4399
Fix #4398

before / after
7d72c899-50cf-40e2-ae4e-3d4b683c9d8f

nginx builds the redirect from the forwarded host and drops the port.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
patrickelectric marked this pull request as ready for review September 3, 2026 22:45
@patrickelectric
patrickelectric requested a review from a team September 3, 2026 22:45
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Moves the inline width/height/style attributes on EndpointCard.vue and EndpointManager.vue into scoped CSS classes and adds a @media (max-width: 600px) block so the MAVLink endpoints page reflows on mobile. Also sets changeOrigin: true and autoRewrite: true on the /ardupilot-manager dev proxy in core/frontend/vite.config.js:255-257, matching the pattern used by other proxied services and fixing redirect/Host handling when the page is accessed through the proxy.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric patrickelectric added the move-to-stable Needs to be cherry-picked and move to stable label Sep 3, 2026

@joaoantoniocardoso joaoantoniocardoso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, waaaay better

@joaoantoniocardoso
joaoantoniocardoso merged commit 27f6937 into bluerobotics:master Sep 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mavlink endpoints page does not work under bun run dev proxy

2 participants