Skip to content

core: frontend: wifi: Freeze network list on hover #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
patrickelectric wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

core: frontend: wifi: Freeze network list on hover #4348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions core/frontend/src/components/wifi/WifiManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@
<v-sheet
max-height="600"
class="overflow-y-auto"
@mouseenter="freezeList"
@mouseleave="hovering_list = false"
>
<div v-if="filtered_networks !== null">
<div v-if="displayed_networks !== null">
<v-text-field
v-if="show_search"
v-model="ssid_filter"
Expand All @@ -66,9 +68,9 @@
clearable
class="ml-7 mr-7"
/>
<div v-if="!filtered_networks.isEmpty()">
<div v-if="displayed_networks && !displayed_networks.isEmpty()">
<wifi-network-card
v-for="(network, key) in filtered_networks"
v-for="(network, key) in displayed_networks"
:key="key"
class="available-network"
:network="network"
Expand Down Expand Up @@ -182,6 +184,8 @@ export default Vue.extend({
show_qr_code_dialog: false,
wifi_qr_code_img: '',
ssid_filter: undefined as string | undefined,
hovering_list: false,
frozen_networks: undefined as Network[] | undefined,
}
},
computed: {
Expand Down Expand Up @@ -210,6 +214,19 @@ export default Vue.extend({
(network) => network.ssid.toLowerCase().includes(filter.toLowerCase()),
)
},
displayed_networks(): Network[] | undefined {
if (!this.hovering_list) {
return this.filtered_networks
}
// eslint-disable-next-line eqeqeq
if (this.ssid_filter == undefined || this.ssid_filter.trim() === '') {
return this.frozen_networks
}
const filter = this.ssid_filter
return this.frozen_networks?.filter(
(network) => network.ssid.toLowerCase().includes(filter.toLowerCase()),
)
},
hotspot_status(): boolean | null {
return wifi.hotspot_status?.enabled ?? null
},
Expand All @@ -232,6 +249,10 @@ export default Vue.extend({
forgetNetwork(network: Network): void {
wifi.forgettNetwork(network)
},
freezeList(): void {
this.frozen_networks = this.connectable_networks
this.hovering_list = true
},
openConnectionDialog(network: Network): void {
this.selected_network = network
this.show_connection_dialog = true
Expand Down