[1.4] Timeout extension pulls from last Docker progress - #4341
Draft
joaoantoniocardoso wants to merge 1 commit into
Draft
[1.4] Timeout extension pulls from last Docker progress#4341joaoantoniocardoso wants to merge 1 commit into
joaoantoniocardoso wants to merge 1 commit into
Conversation
joaoantoniocardoso
marked this pull request as ready for review
August 27, 2026 16:28
joaoantoniocardoso
marked this pull request as draft
August 27, 2026 16:28
Automated PR Review0. Summary
Replaces the axios wall-clock No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3078.
Axios
timeout: 120000on extension update is a wall-clock deadline from request start. A large or slow Docker pull still streams progress, but the UI aborts at two minutes withtimeout of 120000ms exceeded(the install path had no timeout at all).Cancel only after 120s with no new download bytes.
install()uses the same idle watchdog so a hung pull does not sit forever, while a long pull that is still moving is left alone.Test plan
DUT
192.168.0.124(bluerobotics/blueos-core:1.4-dev), managementeth0. Local frontend (BLUEOS_ADDRESS=http://192.168.0.124/) for the UI path.POST /kraken/v1.0/extension/update_to_versionofbluerobotics.jupyter:0.2.0with a 120s total client timeout while the stream was still delivering data (timeout of 120000ms exceeded, last chunk at ~128s)v1.19.0-beta.9completed; no timeout bannerbluerobotics.cockpit:v1.19.0-beta.9: 177 passed, 0 failed; DUT restored toblueos-docs+major_tomLeftover (not this PR): if Docker goes silent for >120s after the last pull line (e.g. deleting leftover tags), the UI can still idle-cancel while the backend finishes. Heartbeats on the kraken stream would cover that.