Repository navigation
Fix[mqb]: removing e_NO_HANDLE_STREAM_PRODUCERS - #1817
Merged
Merged
Conversation
dorjesinpo
changed the title
678098
reviewed
Oct 19, 2026
Comment on lines
+35
to
+36
| << (rhs.isHandleStreamEmpty() ? " isHandleStreamEmpty" : "") | ||
| << (rhs.isQueueStreamEmpty() ? " isQueueStreamEmpty" : "") |
Contributor
There was a problem hiding this comment.
These two look more like a question is smth?
Maybe it is better to name it like queueStreamIsEmpty and handleStreamIsEmpty
Or handleStream: empty and queueStream: empty
| /// Return true if there are no consumers and producers for this | ||
| /// subStream for all handles in this queue. | ||
| /// Return true if there are no clients for this subStream for all | ||
| /// handles in this queue. |
Contributor
There was a problem hiding this comment.
I found it confusing that a handle knows something about all other handles. Can this information become false by manipulating other handles? Can we avoid storing it at all on this level?
Contributor
Author
There was a problem hiding this comment.
This does come not from a handle but from a QueueEngine. As a result of (handle initiated) action.
The result is not cached, it is a return value of the operation.
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/no-stream-producers
branch
from
October 20, 2026 14:34
21112d8 to
da02892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix: removing last fanout app consumer erroneously clears
RemoteQueue::d_pendingMessages.The code mistakenly seeks symmetry supporting both
e_NO_QUEUE_STREAM_CONSUMERSande_NO_QUEUE_STREAM_PRODUCERSwhile producers are per queue and not per stream.Making the
QueueHandleReleaseResultlevel-triggered.