Repository navigation
Fix[mqb]: use 100x multiplier for rc enums reaching -10 - #1814
Merged
Merged
Conversation
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
hallfox
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc * 10 + rc_Xonly work if every localrc_Xis a single digit, so the last digit gives the local code and the rest gives the callee's.IncoreClusterStateLedger::applyImpl(rc_APPLY_RECORD_FAILURE = -10) andFileStore::writeJournalRecord(rc_QUEUE_DELETION_ERROR = -10) break this, so their codes no longer decode correctly. For example, callee-1withrc_APPLY_RECORD_FAILUREgives-20, which reads as callee-2.* 100, the multiplier already used elsewhere for enums that reach-10. No other* 10site in the repo has an enum this deep.