Repository navigation
Fix: Reject URIs with embedded NUL bytes - #98
Merged
Merged
Conversation
This patch adds checks at each place in the Cython layer that accepts a URI (broker endpoint or queue URI) and verifies that there is no embedded NUL byte in the the URI string. If the URI string does contain an embedded NUL byte, an exception is raised. This patch also adds several new tests to verify this. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
This patch adds checks at each place in the Python layer that accepts a URI (broker endpoint or queue URI) and verifies that there is no embedded NUL byte in the the URI string. If the URI string does contain an embedded NUL byte, an exception is raised. This patch also adds several new tests to verify this. In principle, we are okay to rely on the change in the last patch to prevent this bug, but it is better to be explicit about what we consider an error at each layer, in case the code ever changes. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
added
bug
hallfox
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds checks in two places for URI strings with embedded NUL bytes in them: at the Cython layer, and at the Python layer. This ensures that the C++ layer, which traffics in NUL-terminated strings, does not accidentally treat such a string as shorter than the Python code intended. It also includes tests to verify that if embedded NUL bytes are found, exceptions are raised.