Resolve testing issues#16
Merged
Merged
Conversation
This commit makes flake8 ignore "line break after binary operator" (W504), as same as blockdiag.
This commit explicitly specifies exception type at "except" statement, in order to avoid flake8 error "do not use bare 'except'" (E722).
This commit adds 'r' prefix to string literals, which use invalid
escape sequence ('\d', '\s', and '\.'), in order to avoid flake8
warning "invalid escape sequence" (W605).
This changes should be safe enough, because none of 'r' prefixed
string literals contain any valid escape sequence (e.g. '\n', '\\',
and so on).
This dropping should be reasonable, because blockdiag already did so. This changes simplify subsequent changes for tox.ini.
This commit follows dependency configuration style of blockdiag, as
below:
- list up dependencies for testing in setup.py instead of tox.ini,
and specify "[testenv] extras" to install them before testing
- enable "[testenv] usedevelop"
without this, tox fails before testing because "docutils" is not
available, if executed on plain environment.
This commit still keeps empty "[testenv] deps", because this is
referred by "[testenv:blockdiag_dev] deps".
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series resolves issues at testing below:
Unfortunately, some failures below occur even after this series.