fix(forkchoice): include fresh gossip aggregates in proposals - #1057
Open
zclawz wants to merge 1 commit into
Open
fix(forkchoice): include fresh gossip aggregates in proposals#1057zclawz wants to merge 1 commit into
zclawz wants to merge 1 commit into
Conversation
Contributor
Author
|
Status: PR opened for the Hive client-interop aggregation/proposal packaging failure. What changed:
Validation:
Hive reference: https://hive.leanroadmap.org/suite.html?suiteid=1784788366-5a62c8c486eb2725285e622f60315e02.json&suitename=client-interop&client=zeam_devnet5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a live fork-choice/proposal packaging gap exposed by Hive client-interop run
1784788366-5a62c8c486eb2725285e622f60315e02.The run was already using a devnet5 image containing PR #1055, but these failures are a different class: non-aggregator proposers could receive valid aggregate gossip, keep it in
latest_new_aggregated_payloads, and still build blocks from onlylatest_known_aggregated_payloadsbefore the interval-4 promotion pass moved the payload over.Changes
gossip=nonefor selected fresh aggregates.getProposalAttestationsPreAggregatedpath check.Validation
/tmp/zig-x86_64-linux-0.16.0/zig fmt --check pkgs/node/src/forkchoice.ziggit diff --check/tmp/zig-x86_64-linux-0.16.0/zig build --fetch --summary none/tmp/zig-x86_64-linux-0.16.0/zig build all --fetch --summary noneAttempted full
zig build test --summary allwith Zig 0.16.0, but this container still cannot run the test target becauserustupis missing:Before that external failure, the already-started preset/utils/metrics test groups passed, matching the previous environment limitation.
Hive run investigated: https://hive.leanroadmap.org/suite.html?suiteid=1784788366-5a62c8c486eb2725285e622f60315e02.json&suitename=client-interop&client=zeam_devnet5