Move fincFdecTests to software - #1327
Merged
Merged
Conversation
hiddemoll
force-pushed
the
hidde/software-fincfdectests
branch
from
June 12, 2026 11:40
ca7b221 to
08cdb34
Compare
martijnbastiaan
changed the title
fincFdecTests to software
martijnbastiaan
approved these changes
Jun 12, 2026
hiddemoll
force-pushed
the
hidde/software-fincfdectests
branch
from
June 12, 2026 14:53
08cdb34 to
76fd772
Compare
hiddemoll
force-pushed
the
hidde/software-fincfdectests
branch
5 times, most recently
from
June 18, 2026 13:47
448bdd6 to
0549d71
Compare
rslawson
requested changes
Jun 18, 2026
rslawson
left a comment
rslawson
left a comment
Collaborator
There was a problem hiding this comment.
Only change I actually would like done for this PR is the one about the unnecessary &dyn, the other ones can be left until a later date.
hiddemoll
force-pushed
the
hidde/software-fincfdectests
branch
4 times, most recently
from
June 24, 2026 07:59
b21c89c to
35e83a3
Compare
Contributor
Author
|
@lmbollen, could you review the very last commit where I add a rust macro to call all tests? |
rslawson
approved these changes
Jun 25, 2026
`fincFdecTests` uses a domain difference counter to check whether requested speed changes actually increment or decrement the frequency of the external clock. To achieve this the external clock needs to be roughly the same frequency as what the logic runs on. Previously both were 200 MHz, but our VexRiscv cannot run at that frequency. As a temporary solution we add a clock configuration for a clock of 125 MHz. Once we can run a CPU at 200 MHz we will remove the configuration for 125 MHz.
hiddemoll
force-pushed
the
hidde/software-fincfdectests
branch
from
June 25, 2026 12:53
35e83a3 to
2bea23d
Compare
hiddemoll
enabled auto-merge
June 25, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Move
fincFdecTeststo software.Why (context, issues, etc.)
Prerequisite for #1118
Dear reviewer (anything you'd like the reviewer to pay close attention to?)
Requesting @martijnbastiaan for everything except the Rust, and requesting @rslawson specifically for the Rust.
I'm not super happy with the rust firmware (AI generated). It has a lot of very similar functions, but the hardware and software versions differ ever so slightly; HW only needs to set the
SpeedChangeonce, but also set it toNoChangeat the end, while SW has to keep doing SPI write operations to the FINC/FDEC register. @rslawson are you happy with it as is? If not, do you have some tips on how to improve it?AI disclaimer (heads-up for more than inline autocomplete)
Only for the rust code.
TODO
Cross-outany that do not apply[ ] Update documentation, includingdocs/