Skip to content
This repository was archived by the owner on Aug 31, 2026. It is now read-only.

adding stop method for xrp #117

Open
sbhatnagar30 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adding stop method for xrp #117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ceb06d
adding stop method for xrp
sbhatnagar30 Apr 1, 2020
585ab4b
Merge branch 'master' of github.com:bitpay/crypto-rpc into stopXRP
sbhatnagar30 May 13, 2020
485bfbf
adding dummy methods to each rpc
sbhatnagar30 May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ class CryptoRpcProvider {
getAccountInfo(params) {
return this.get(params.currency).getAccountInfo(params);
}

stop(params) {
return this.get(params.currency).stop();

@jackbonaguro jackbonaguro Apr 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would want this method to exist on other implementations, at least as a stub

@sbhatnagar30 sbhatnagar30 May 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally addressed this

}
}

module.exports = CryptoRpcProvider;
4 changes: 4 additions & 0 deletions lib/xrp/XrpRpc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,10 @@ class XrpRpc {
getAccountInfo({ address }) {
return this.asyncRequest('account_info', { account: address });
}

async stop() {
await this.rpc.disconnect();
}
}

module.exports = XrpRpc;