Skip to content

.clang-tidy: Enable additional checks - #380

Merged
ryanofsky merged 3 commits into
bitcoin-core:masterfrom
maflcko:2610-tidy
Nov 3, 2026
Merged

ryanofsky merged 3 commits into
bitcoin-core:masterfrom
maflcko:2610-tidy

Conversation

@maflcko

@maflcko maflcko commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Just a few checks, which I think make sense:

  • Some bugprone checks from upstream
  • Some more bugprone checks, which I consider useful
  • Some modernize checks, which I consider useful

All checks pass cleanly on the codebase

@DrahtBot

DrahtBot commented Oct 22, 2026 •

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@maflcko

maflcko commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Not sure what the openbsd ci failure is, but it seems unrelated, as no source code is changed here, only a config file

@hebasto

hebasto commented Oct 22, 2026

Copy link
Copy Markdown
Member

Not sure what the openbsd ci failure is, but it seems unrelated...

FWIW, the OpenBSD job has switched to release 8.0.

@hebasto

hebasto commented Oct 22, 2026

Copy link
Copy Markdown
Member

Not sure what the openbsd ci failure is, but it seems unrelated, as no source code is changed here, only a config file

The issue is supposed to be fixed in #381.

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fabc490.

@ryanofsky
ryanofsky merged commit 796dd74 into bitcoin-core:master Nov 3, 2026
14 checks passed
@maflcko
maflcko deleted the 2610-tidy branch November 3, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants