Skip to content

util: Error out at compile time if KJ_NO_EXCEPTIONS is set #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanofsky wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

util: Error out at compile time if KJ_NO_EXCEPTIONS is set #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/mp/proxy-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
#include <typeindex>
#include <vector>

// KJ exception support is required, or exceptions thrown in serverInvoke below go uncaught
// and crash the process instead of being returned to the client as errors.
#if KJ_NO_EXCEPTIONS
#error "KJ_NO_EXCEPTIONS=1 is set but libmultiprocess requires support for exceptions. Please check build settings. On NetBSD you may also need to set -DKJ_NO_EXCEPTIONS=0 -DKJ_NO_RTTI=0 explicitly (https://github.com/capnproto/capnproto/pull/2756)"

@hebasto hebasto Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the comment about -DKJ_NO_RTTI=0 is technically correct, setting the flag isn't necessary in practice.

@ryanofsky ryanofsky Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the comment about -DKJ_NO_RTTI=0 is technically correct, setting the flag isn't necessary in practice.

Thanks, I only saw the failing CI run in bitcoin/bitcoin#36058 and wasn't sure what was needed to make CI pass. I believe KJ_NO_RTTI is good to set though to improve exception error messages.

#endif

namespace mp {

template <typename Value>
Expand Down
Loading