fix: ActivityListModel threading race and deprecated injected event params - #886
Open
uqlidi wants to merge 2 commits into
Open
fix: ActivityListModel threading race and deprecated injected event params#886uqlidi wants to merge 2 commits into
uqlidi wants to merge 2 commits into
Conversation
uqlidi
force-pushed
the
fix/activitylist-race-and-injected-event-params
branch
from
September 7, 2026 20:13
ea647b8 to
3138c7c
Compare
Contributor
Author
|
Force push to rebase and remove merge commit to make it cleaner |
uqlidi
force-pushed
the
fix/activitylist-race-and-injected-event-params
branch
from
September 9, 2026 12:18
3138c7c to
fc5c3e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityListModelwas updated straight from the wallet's transaction-changed callback, which arrives on validation and network threads, while the GUI thread andActivityFilterProxyModelread the same model. The notification is now queued onto the model thread, like the other wallet-signal handlers inWalletQmlModelalready do. Fix ActivityListModel mutates from wallet notification threads and can crash its proxy #870The
Return,EnterandTabhandlers inCommandConsole.qmlused an undeclaredevent, relying on Qt's deprecated signal-parameter injection. They now declare the parameter explicitly. Fix CommandConsole relies on deprecated injected event parameters #869