Redesign settings with reusable form design system by pseudoramdom · Pull Request #872 · bitcoin-core/gui-qml

pseudoramdom · 2026-08-19T18:30:17Z

Summary

The legacy settings pages evolved through several different layout systems, producing inconsistent widths, typography, spacing, navigation patterns, and information hierarchy. This redesign intends to consolidate them in to one coherent, reusable system.

Add shared settings page, heading, form section, row, text-field, link, value, and picker controls
Group related destinations under Wallet, General, Network, and Advanced
Redesign the wallet, external signer, display, window behavior, storage, connection, proxy, network traffic, mempool, debug log, and about pages
Delete the replaced legacy settings pages
Update QML and functional tests for the new settings hierarchy
Move the RPC console into the settings

Implementation details

Introduce generic controls such as FormSection, FormRow, ValueRow, LinkRow, TextFieldRow, and PopupPicker provide consistent layout and interaction behavior.
SettingsView owns the fixed sidebar, destination definitions, visibility rules, and selected section.
SettingsPageContainer lazily creates a navigation stack for each visited section and preserves nested navigation when switching sections.
SettingsPage standardizes page headings, scrolling, horizontal padding, and readable content widths.
Simple choices use inline segmented controls or popup pickers instead of dedicated selection pages.
Standard form pages use a bounded readable width, while Network Traffic and Debug Log can use the available width with responsive side padding.
Network Traffic, Debug Log, and RPC Console activity follows page visibility to avoid unnecessary background work.
Wallet availability, desktop-only destinations, and mempool availability continue to control which sidebar items are shown.
Existing settings entry points now open the redesigned view, while the superseded legacy pages and top-bar RPC Console entry are removed.
Onboarding retains its existing connection and storage flows.

Preview

Settingsv2.mp4

johnny9

GUI: qrc:/qml/controls/TextFieldRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/controls/TextFieldRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/controls/ValueRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/controls/LinkRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/controls/LinkRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/pages/settings/SettingsDesignSystem.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/pages/settings/SettingsDesignSystem.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/pages/settings/SettingsDesignSystem.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:42Z GUI: qrc:/qml/pages/settings/SettingsDesignSystem.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:54Z GUI: qrc:/qml/controls/TextFieldRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:54Z GUI: qrc:/qml/controls/ValueRow.qml: Cannot instantiate bound component outside its creation context
2026-08-20T22:43:54Z GUI: qrc:/qml/controls/ValueRow.qml: Cannot instantiate bound component outside its creation context from

Getting these errors in the new settings pages. I think its related to the Loaders in the FormRow. My suggestion is to remove the Loaders and use a different container and I think it should force constructing the pages in a way where this wont happen. This might be 6.4 specific too (ubuntu 24.04).

pseudoramdom · 2026-08-25T04:03:41Z

CI is happy now

Introduce reusable SettingsPage, PageHeading, and FormSection controls. These provide constrained scrollable page content, consistent heading typography, and card-style sections with optional headers and footers. They are not wired into existing settings screens yet.

Add generic form, list, link, value, and textfield rows for settings screens. The controls provide consistent typography, dividers, disclosure indicators, disabled states, and composable leading, trailing, and body content. They are not wired into settings pages just yet.

Add PopupPicker, a compact control that composes a DropdownButton, ContextMenu, and ContextMenuPicker. The control displays the current selection and manages opening, selecting, and closing the menu. It is intended for composition as the trailing control of a FormRow rather than as a settings row itself. Extend ContextMenuPicker with optional leading icons and icon-aware layout for richer selection choices.

Update context-menu surfaces and hover states to use the revised neutral palette. Improve segmented-picker contrast in light mode and standardize disclosure indicators to the compact settings-row size.

Rework the design-system page to use SettingsPage, FormSection, and the generic row controls. Add representative examples for switches, pickers, navigation, values, links, inline text fields, and supporting content. Cover the shared form components and their composition with QML tests.

Add a settings sidebar and a container that lazily creates and preserves a navigation stack for each visited section.

Add a second Settings tab alongside the existing settings interface so the redesign can be reviewed while pages are migrated incrementally. Lazily create the redesigned settings view on first use and retain it across top-level tab switches to preserve its navigation state.

Populate the sidebar-based settings view with redesigned Wallet, External signer, Display, Window behavior, Storage, Connection, Network traffic, Mempool information, and About pages. Integrate Debug log into the same constrained page container. Compose the pages from the shared settings controls while preserving existing models, validation, actions, and nested navigation flows. Wire wallet-related actions back to the desktop wallet view. Suspend Network Traffic and Debug Log activity while their cached pages are hidden. Add QML coverage for section navigation, stack preservation, page layout, picker mappings, proxy draft handling, lifecycle behavior, and top-level destination creation.

Add a prominent Settings heading and organize sidebar destinations under Wallet, General, Network, and Advanced group labels.

Delete unused legacy settings pages and tests, update navigation and resource wiring, and migrate functional coverage to Settings v2.

Move the redesigned settings pages into the main settings directory and remove the settingsv2 prefix from QML object names and test selectors.

johnny9

Pop wallet subpages whenever the selected wallet changes or becomes unavailable.

johnny9 · 2026-09-09T16:21:35Z

+        target: typeof walletController !== "undefined" ? walletController : null
+
+        function onSelectedWalletChanged() {
+            if (root.selectedSectionId === "wallet" && pageContainer.depth > 1) root.selectSection("wallet", true)


Open “Set password” for an unencrypted wallet, switch to Display, select an encrypted wallet, then return to Wallet. The cached password page retains updating: false while its wallet binding changes, so it attempts encryption instead of a password change. Unloading the wallet while another section is selected also leaves the subpage open. Reset the cached wallet stack independently of the selected section, and add regression coverage for switching and unloading wallets while that stack is hidden.

Good catch. Should be fixed now.

Reset the wallet section stack when the selected wallet changes or is unloaded, even when another settings section is visible. This prevents cached wallet subpages from retaining state belonging to the previous wallet. Add regression coverage for switching and unloading wallets while the wallet settings stack is hidden.

johnny9

ACK bd137af

The reported regression is fixed: switching or unloading wallets pops cached wallet subpages without changing the selected settings section. Both added regression tests and the original reproduction checks pass.

johnny9 reviewed Aug 21, 2026

View reviewed changes

pseudoramdom force-pushed the settings-redesign-v2 branch 4 times, most recently from 0262899 to 19c4c50 Compare August 24, 2026 20:52

pseudoramdom force-pushed the settings-redesign-v2 branch from 19c4c50 to 60f6f5c Compare August 25, 2026 05:08

pseudoramdom mentioned this pull request Aug 25, 2026

Redesign addresses list and wallet settings pages #874

Open

pseudoramdom force-pushed the settings-redesign-v2 branch from 60f6f5c to e229df1 Compare August 26, 2026 21:01

pseudoramdom mentioned this pull request Aug 26, 2026

Redesign RPC console and debug log pages #877

Open

pseudoramdom added 12 commits September 8, 2026 10:55

qml: polish shared settings controls

ea39555

Update context-menu surfaces and hover states to use the revised neutral palette. Improve segmented-picker contrast in light mode and standardize disclosure indicators to the compact settings-row size.

qml: add sidebar-based settings navigation shell

e0429dd

Add a settings sidebar and a container that lazily creates and preserves a navigation stack for each visited section.

qml: group related settings sidebar items

330cd2a

Add a prominent Settings heading and organize sidebar destinations under Wallet, General, Network, and Advanced group labels.

qml: move RPC console to redesigned settings

1a0ec8e

qml: delete legacy settings pages

a608c98

Delete unused legacy settings pages and tests, update navigation and resource wiring, and migrate functional coverage to Settings v2.

qml: drop settingsv2 prefix naming

776029d

Move the redesigned settings pages into the main settings directory and remove the settingsv2 prefix from QML object names and test selectors.

pseudoramdom force-pushed the settings-redesign-v2 branch from e229df1 to 776029d Compare September 8, 2026 19:05

qml: update to be compatible with Qt 6.2

df0f113

pseudoramdom requested a review from johnny9 September 9, 2026 04:40

johnny9 suggested changes Sep 9, 2026

View reviewed changes

pseudoramdom mentioned this pull request Sep 9, 2026

Redesign peers list #889

Open

johnny9 approved these changes Sep 9, 2026

View reviewed changes

hebasto merged commit 72cf16d into bitcoin-core:qt6 Sep 9, 2026
7 of 8 checks passed

This was referenced Sep 10, 2026

Add desktop application menu bar #876

Merged

Activity: advanced filters, edited request labels, and used-address requests #817

Merged

Navigation Menu

Uh oh!

Redesign settings with reusable form design system - #872

Redesign settings with reusable form design system#872
hebasto merged 14 commits into
bitcoin-core:qt6from
pseudoramdom:settings-redesign-v2

pseudoramdom commented Aug 19, 2026

Uh oh!

johnny9 left a comment •

edited

Loading

Uh oh!

pseudoramdom commented Aug 25, 2026

Uh oh!

johnny9 left a comment •

edited

Loading

Uh oh!

johnny9 Sep 9, 2026

Uh oh!

pseudoramdom Sep 9, 2026

Uh oh!

johnny9 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pseudoramdom commented Aug 19, 2026

Summary

Implementation details

Preview

Uh oh!

johnny9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pseudoramdom commented Aug 25, 2026

Uh oh!

johnny9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnny9 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

pseudoramdom Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

johnny9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnny9 left a comment •

edited

Loading

johnny9 left a comment •

edited

Loading