qml: Fix onboarding data directory failures - #864
Closed
johnny9 wants to merge 3 commits into
Closed
Conversation
johnny9
force-pushed
the
fix-onboarding-top3
branch
from
August 18, 2026 02:08
8b425d4 to
2f0b943
Compare
johnny9
marked this pull request as ready for review
August 18, 2026 03:04
johnny9
force-pushed
the
fix-onboarding-top3
branch
2 times, most recently
from
August 25, 2026 02:11
af67176 to
1db6db4
Compare
johnny9
force-pushed
the
fix-onboarding-top3
branch
from
September 2, 2026 00:30
1db6db4 to
a4db11b
Compare
Keep the datadir selected in onboarding separate from the path Core resolves after config parsing. Run pre-init preview and apply through a scratch ArgsManager seeded from the original argv so live gArgs reaches InitConfig without preloaded config or settings state. Finalize onboarding settings after InitConfig and chain-specific QSettings setup. Apply reset across Core and GUI stores transactionally, preserve strDataDir, honor final source precedence, and recover unreadable settings with the Qt reset-or-abort behavior. Only open and synchronize settings stores that are used or modified, preserving rollback without allowing unrelated stores to block startup. Add unit and functional coverage for datadir precedence, reset behavior, recovery, persistence, and rollback.
johnny9
force-pushed
the
fix-onboarding-top3
branch
from
September 5, 2026 17:30
a4db11b to
e7619aa
Compare
Collaborator
Author
|
Superseded by #883 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #812.
This branch is based on the current head of #812. Until #812 merges, this pull request also includes that commit.
This fixes three onboarding failures:
Tests:
Fixes #775.
Fixes #783.
Fixes #846.