Prevent recurrence: Two current Pidgin labels repeat “Privet”. Verify whether the current validation pipeline checks kn…

[hiciefte]

Localize Guardian — automated prevention proposal

Source pull requests:

• bisq-network/bisq-mobile #1805

Proposed fix

Automated proposal for maintainer review.

Root cause: Two current Pidgin labels repeat “Privet”. Verify whether the current validation pipeline checks known locale-specific misspellings; a regression fixture containing both labels should flag “Privet” while accepting “Private”. The bundle does not establish why the typo passed.

Review evidence

Based on 1 reviewed feedback items and the regression checks below.

Bounded patch

Base commit: 5a3c02c

Proposed fix (a direct child of that base): 82895a6

• localize/semantic_quality.py
• tests/unit/test_semantic_quality.py

Regression proof supplied by the controller

The same focused regression checks failed on the exact base and passed on its direct child:

Runner names are shown below; local paths and exact commands stay in the private audit.

• pytest: failed before the fix; passed after the fix.

Publication of this proposal requires a separate broker to re-verify current state and publish only this signed candidate. The Guardian cannot merge or deploy prevention proposals.

Summary by CodeRabbit

• Bug Fixes
  • Improved translation quality checks for Nigerian Pidgin by flagging “privet” when “private” is expected. Affected translations are reported as errors and can block the quality gate.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 49ce82cf-18f6-46c2-9c74-22209d5faa8d

📥 Commits

Reviewing files that changed from the base of the PR and between 5a3c02c and 82895a6.

📒 Files selected for processing (2)

• localize/semantic_quality.py
• tests/unit/test_semantic_quality.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The semantic quality check now applies a built-in Nigerian Pidgin rule that flags “Privet” when the source text matches “Private.” A unit test checks the reported translation errors and blocking quality-gate result.

Changes

PCM spelling rule

Layer / File(s)	Summary
Define the PCM spelling rule localize/semantic_quality.py	Adds a case-insensitive rule for locale pcm. It matches source text “private” and target text “privet”.
Apply and test the built-in rule localize/semantic_quality.py, tests/unit/test_semantic_quality.py	analyze_translation_changes evaluates configured rules and built-in spelling rules. The test checks errors for two translated labels and a blocking quality-gate report.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 82895

The rule flags the intended typo and accepts “Private” for the configured locale. No actionable merge-blocking issue remains after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the Pidgin “Privet” spelling issue and the goal of preventing recurrence. It is longer and less direct than the change, which adds a built-in semantic quality rule, but it still d…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each word with care,
“Private” hops; “Privet” isn’t there.
The rule spots spelling gone astray,
And marks the gate to block the way.
Then off I go, with carrots to spare!}

_{Comment @coderabbitai help to get the list of available commands.}