Silence resolved Guardian reviewer replies

[hiciefte]

Repeated CodeRabbit withdrawals on Bisq2 #5059 triggered new Guardian replies, continuing the same review loop. Keep the nine recorded resolved acknowledgement forms private after a completed no-op assessment, while continuing to assess every revision and report new findings or required decisions.

The publication filter requires authenticated CodeRabbit feedback, actual review-reply metadata, the exact resolved wrapper and acknowledgement grammar, and an assessment with no applied, held, or deferred edits. Root comments, unknown formats and mixed actionable text remain reportable.

Validation: 518 reporting/controller/GitHub tests passed, including all nine recorded replies across reporting history and fresh-feedback scenarios, interior mixed-text controls and reply-parent parsing. Ruff and diff checks passed. Independent review accepted the exact patch. Full suite: 3,375 passed, one skipped, 13 subtests passed.

Summary by CodeRabbit

• Bug Fixes
  • Prevented resolved reviewer replies that withdraw already-addressed or inapplicable findings from being reported as new feedback.
  • Replies are suppressed only when they match a recognized withdrawal acknowledgement and the finding is assessed as already addressed or not applicable.
  • Replies containing edits, action requests, meaningful changes, or assessments requiring human input remain reportable. Root comments are not treated as withdrawal replies.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ca996e14-3906-4dc7-a2be-a5173b30457e

📥 Commits

Reviewing files that changed from the base of the PR and between 39a1bf8 and 1045d0c.

📒 Files selected for processing (3)

• localize/guardian/github.py
• tests/unit/test_guardian_github.py
• tests/unit/test_guardian_reporting.py

🚧 Files skipped from review as they are similar to previous changes (2)

• tests/unit/test_guardian_github.py
• tests/unit/test_guardian_reporting.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change parses parent comment IDs for GitHub review replies and filters qualifying resolved CodeRabbit acknowledgements from feedback reports. Tests cover parsing, filtering conditions, and controller integration.

Changes

Quiet reviewer reply reporting

Layer / File(s)	Summary
Parse reply parent metadata localize/guardian/github.py, tests/unit/test_guardian_github.py	FeedbackRevision stores an optional in_reply_to_id. Parsing and tests cover payloads with and without the parent ID.
Classify and suppress resolved replies localize/guardian/reporting.py, localize/guardian/controller.py, tests/unit/fixtures/guardian_5059_withdrawals.json, tests/unit/test_guardian_reporting.py, tests/unit/test_guardian_controller.py	The reporting filter recognizes qualifying resolved acknowledgements. The controller applies it to events that match snapshot replies. Fixtures and tests cover quiet and reportable replies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1045d

The change quiets narrowly matched resolved acknowledgements while keeping root review comments and actionable replies reportable. No current reporting risk is established that should block merging.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: silencing resolved Guardian reviewer replies.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 6 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit reads the thread at dawn,
And finds the parent ID drawn.
Resolved replies that fit the rule
Stay quiet; other notes pass through.
Tests watch each reply’s path with care,
Then tuck the report beneath the hare.}

_{Comment @coderabbitai help to get the list of available commands.}

[hiciefte]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.