Skip to content

[Localize Guardian bot] Historical translation corrections - #5057

Merged
bisqadmin merged 1 commit into
bisq-network:mainfrom
hiciefte:localization/guardian-remediation-fa9b8002fd9f4547676ebc038105e0957bb773084fa6bdc4a973238ec5284b26
Oct 2, 2026
Merged

bisqadmin merged 1 commit into
bisq-network:mainfrom
hiciefte:localization/guardian-remediation-fa9b8002fd9f4547676ebc038105e0957bb773084fa6bdc4a973238ec5284b26

Conversation

@hiciefte

@hiciefte hiciefte commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Localize Guardian — automated translation corrections

Bot-generated pull request for human review only.

This current-base candidate does not modify or comment on the closed source pull requests and is never merged automatically.

Historical source pull requests:

Validated review feedback:

Changed localization files: 1
Changed translation entries: 1

Review the changed strings and existing checks before merging.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Vietnamese warning shown when taking an offer from an ignored maker. It now directs users to the maker’s profile to stop ignoring them, replacing the previous instruction to cancel ignoring on the profile. This gives Vietnamese-speaking users clearer guidance on where to change their settings before proceeding with the offer.

Created by the Localize Guardian bot for human review.

Historical evidence: 63f0df73fe559fcd6372686bda848a5bf02ee9a88d4f39953db032b69377c580

Validated historical feedback:
- bisq-network#4892 (comment)
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 0e8e36a3-fb9b-4811-b884-d9c50cf0b821

📥 Commits

Reviewing files that changed from the base of the PR and between 39e2a50 and ecd4236.

📒 Files selected for processing (1)
  • i18n/src/main/resources/mu_sig_vi.properties

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The Vietnamese warning for taking an offer from an ignored maker now identifies the offer maker and directs users to the maker’s profile to stop ignoring them.

Changes

Ignored-maker warning

Layer / File(s) Summary
Update warning text
i18n/src/main/resources/mu_sig_vi.properties
The Vietnamese warning now directs users to the maker’s profile to stop ignoring them.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ecd42

The warning directs users to a usable way to stop ignoring the offer maker, and the offerbook provides a direct shortcut. No actionable merge risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to ecd42

The change affects 1 system.

Changed systems: i18n

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — i18n (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in i18n/src/main/resources/mu_sig_vi.properties: Updated the ignored-maker warning to say the user ignored the offer maker and to direct them to the maker’s profile to stop ignoring them; the previous wording referred to the maker as the person who created the offer and instructed users to cancel ignoring on the profile.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies a historical translation correction generated by the Localize Guardian bot. It matches the localization-only change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the warning anew
The maker’s profile comes into view
One phrase now points the way
To stop ignoring, clear and plain
Then hops along its way.

Comment @coderabbitai help to get the list of available commands.

@bisqadmin

Copy link
Copy Markdown
Contributor

utACK

@bisqadmin
bisqadmin merged commit 745d999 into bisq-network:main Oct 2, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants