rework termination mac handling - #396
Draft
KanjiMonster wants to merge 1 commit into
Draft
Conversation
KanjiMonster
marked this pull request as draft
October 27, 2022 09:01
KanjiMonster
force-pushed
the
jogo_termmac_rework
branch
2 times, most recently
from
December 13, 2022 09:51
3400a47 to
ea27328
Compare
KanjiMonster
force-pushed
the
baseboxd-2.0
branch
from
March 7, 2023 13:25
3c6cdba to
7886f8b
Compare
Rework termination mac handling by tying termination mac entries to interfaces: * create entries on interface creation * remove them on interface deletion with the values of * port_id, vid 0 for the base port/bond interface (any vid) * port_id, vid for vlan interfaces on top of those * port_id 0, vid 0 for the base bridge interface (any port, any vid) * port_id 0, vid for vlan interface on top of bridge Since these combinations are unique, we can just add/remove the entries without the need of having refcounts. Advantages: * simplication of code * ip addresses assigned to lo will just work Disadvantages: * higher use of termination mac flows, which are limited (0.5k to 1k), so only (256 - ports) to (512 - ports) number of vlan/bridge/bond interfaces are supported * (this is a lie though, since both termination mac entries for an interface share the same underlying resource) Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_termmac_rework
branch
from
August 21, 2026 13:06
ea27328 to
00e5761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework termination mac handling by tying termination mac entries to
interfaces:
with the values of
Since these combinations are unique, we can just add/remove the entries
without the need of having refcounts.
Advantages:
Disadvantages:
so only (256 - ports) to (512 - ports) number of vlan/bridge/bond
interfaces are supported
interface share the same underlying resource)
Open Questions:
resources?
Signed-off-by: Jonas Gorski jonas.gorski@bisdn.de