Add View Options (title and axis titles) to Distributions widget#7302
Open
SofianElmotiem wants to merge 3 commits into
Open
Add View Options (title and axis titles) to Distributions widget#7302SofianElmotiem wants to merge 3 commits into
SofianElmotiem wants to merge 3 commits into
Conversation
Implements biolab#7298. Adds custom plot title and custom x/y axis title support to the Distributions widget View Options dialog, consistent with Line Plot, Bar Plot and Violin Plot. Also includes a small fix for Create Class: the widget did not resize when rule rows were added/removed, and the rule list had no height cap.
|
|
VesnaT
reviewed
Jun 19, 2026
| min(content_height, self.MAX_RULES_AREA_HEIGHT)) | ||
| self.adjustSize() | ||
|
|
||
| if getattr(self, "_scroll_to_bottom_pending", False): |
Contributor
There was a problem hiding this comment.
self._scroll_to_bottom_pending should be defined within __init__ and addressed as:
if self._scroll_to_bottom_pending:
self._scroll_to_bottom_pending = False
...
VesnaT
reviewed
Jun 19, 2026
|
|
||
| want_main_area = False | ||
| buttons_area_orientation = Qt.Vertical | ||
| #: Max pixel height of the rules area before it scrolls instead of |
| @@ -331,6 +343,8 @@ def __init__(self): | |||
| # TODO: Resizing upon changing the number of rules does not work | |||
| self.setSizePolicy(QSizePolicy.Preferred, QSizePolicy.Maximum) | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Remove the extra blank lines.
| @@ -331,6 +343,8 @@ def __init__(self): | |||
| # TODO: Resizing upon changing the number of rules does not work | |||
| def _refit_rules_area(self): | ||
| """Size the rules scroll area to its contents, but never taller than | ||
| MAX_RULES_AREA_HEIGHT (beyond that it scrolls, so the Apply button | ||
| stays on screen), then re-fit the window to its new contents.""" |
Contributor
There was a problem hiding this comment.
Remove the docstring. It's not needed for the protected function, besides the name of the function is representative enough.
| content_height = self._rules_widget.sizeHint().height() | ||
| needs_scroll = content_height > self.MAX_RULES_AREA_HEIGHT | ||
| self._rules_scroll.setVerticalScrollBarPolicy( | ||
| Qt.ScrollBarAlwaysOn if needs_scroll else Qt.ScrollBarAlwaysOff) |
Contributor
There was a problem hiding this comment.
This line is not needed. The setFixedHeight will suffice.
- complete the MAX_RULES_AREA_HEIGHT comment - remove stale TODO and extra blank lines - drop docstring from the protected _refit_rules_area - remove the redundant scrollbar-policy line; setFixedHeight already makes the scroll area show its bar only when content overflows
Author
|
Pushed fixes for all the review comments above (import spacing, _scroll_to_bottom_pending init, comment, docstring, redundant scrollbar line). Also noticed the failing checks (lint, Latest py3.14 on all platforms, most Released jobs) are failing the same way on master directly, so it looks unrelated to this PR ,happy to investigate further if I'm missing something though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #7298.
Adds custom plot title and custom x/y axis title support to the Distributions widget View Options dialog, consistent with Line Plot, Bar Plot and Violin Plot. Empty fields fall back to the existing automatic behaviour (variable name / "Frequency"), and the new settings are saved with the workflow like any other visual setting.
Also includes a small fix for Create Class: the widget did not resize when rule rows were added or removed, and the rule list had no height cap.
This was done as a student project; happy to adjust based on review feedback.