Merged
Conversation
agchan12
marked this pull request as ready for review
July 20, 2026 11:43
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 57cabaa. Configure here.
animesh1987
reviewed
Jul 20, 2026
agchan12
force-pushed
the
BACK-786
branch
2 times, most recently
from
July 20, 2026 11:56
82d7e39 to
b62a589
Compare
animesh1987
approved these changes
Jul 20, 2026
agchan12
force-pushed
the
BACK-786
branch
3 times, most recently
from
July 20, 2026 12:03
8d76c35 to
ccda8db
Compare
… when backorder message ID is null
rtalvarez
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
nullguard from simple/complex and picklist products.backorder_message_idsfrom products can benull. When they arenullit means they are the current default. We still need to display the backorder message when the ID is null.Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Before
Setup
Product 103 is set to use the default backorder message 1
Backorder message is set to display in the PDP
BACK-786-before.mov
Explanation
On the PDP, the backorder message does not display because of the
nullguard if the backorder message is nullAfter
Setup
Product 103 is set to use the default backorder message 1
Backorder message is set to display in the PDP
BACK-786-after.mov
Explanation
On the PDP, the backorder message does display when the backorder message is set
nullping @animesh1987 @bigcommerce/team-trac
Note
Low Risk
Localized PDP/picklist display logic with no auth or checkout impact; behavior change only affects when backorder message text appears.
Overview
PDP backorder copy now resolves through a shared
findByBackorderMessageIdOrDefaulthelper instead of requiring a non-nullbackorder_message_id.When a product (or picklist-linked product) has
backorder_message_idnull—meaning “use the store default”—or points at a deleted message, the theme shows the message markedis_defaultinbackorderMessages. The main PDP backorder text (updateBackorderMessage) and picklist backorder suffixes (lookupBackorderMessage) both use this path; earliernullguards that skipped lookup entirely are removed so default messaging can appear. If the default record exists but its message text is empty, nothing is shown (unchanged empty-state behavior).Unit coverage was added for PDP and picklist fallback, dangling IDs, and blank defaults.
Reviewed by Cursor Bugbot for commit bdca36a. Bugbot is set up for automated code reviews on this repo. Configure here.