-
Notifications
You must be signed in to change notification settings - Fork 623
Update translations #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update translations #2707
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -834,7 +834,10 @@ | |
| "suffix": "L'unité" | ||
| } | ||
| }, | ||
| "card_default_image_alt": "Image disponible bientôt" | ||
| "card_default_image_alt": "Image disponible bientôt", | ||
| "featured_promotions": { | ||
| "more_offers": "{count, plural, une {more offer} other {more offers}}" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. English text in localesMedium Severity New Additional Locations (2)Reviewed by Cursor Bugbot for commit 0a10fb0. Configure here. |
||
| } | ||
| }, | ||
| "invoice": { | ||
| "for_order": "Facture {name} de la commande n° {id}", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -834,7 +834,10 @@ | |
| "suffix": "それぞれ" | ||
| } | ||
| }, | ||
| "card_default_image_alt": "画像は近日公開予定" | ||
| "card_default_image_alt": "画像は近日公開予定", | ||
| "featured_promotions": { | ||
| "more_offers": "{count, plural、オファーが他} other { 件}}" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Japanese plural string malformedHigh Severity The new Reviewed by Cursor Bugbot for commit 0a10fb0. Configure here. |
||
| } | ||
| }, | ||
| "invoice": { | ||
| "for_order": "{name}注文番号 #{id}の請求書", | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICU plural uses wrong keyword
Medium Severity
Several new
more_offersstrings use locale words (ét,ein,ett,una,une) as ICU plural selectors instead of the required keywordone. Whencountis 1, the formatter selects theonecategory but no matching arm exists, so it falls back tootherand shows plural wording (e.g. German “weitere Angebote” instead of “weiteres Angebot”).Additional Locations (2)
lang/de.json#L838-L839lang/es.json#L838-L839Reviewed by Cursor Bugbot for commit 0a10fb0. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@funivan these keywords (
one,other, etc.) are part of theICU MessageFormatsyntax itself and must stay in English exactly as one/other — only the text inside the{...}after each keyword should be translated.