feat: enable Pickup V2 batch pickup via env flag#7
Closed
albertoleon7794 wants to merge 1 commit into
Closed
Conversation
Replace hardcoded BC Gov mediator URL check with MEDIATOR_USE_V2_BATCH_PICKUP. When true, agent startup initiates Pickup V2 live mode and batch pickup for Credo-TS mediators. Refs #4 Signed-off-by: Alberto L <aleon@law.harvard.edu>
Collaborator
Author
|
Superseded by #14 (Phase 4): the mediator pickup was simplified to unconditional PickUpV2LiveMode (WebSocket push from the mediator), and the MEDIATOR_USE_V2_BATCH_PICKUP env flag this PR introduced was removed entirely. Verified via two-device E2E VRC exchange against the hosted mediator on live-mode-only pickup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MEDIATOR_USE_V2_BATCH_PICKUPenv flagtrue, agent startup initiates Pickup V2 live mode + batch pickup (required for Credo-TS mediators)false/unset, no special startup pickup — avoids wrong strategy for legacy acapy mediatorsapp/.env.sample(defaults tofalse; prod URL stays in env config only)Closes #4
Context
Dropped connections and missed offline messages were traced to implicit/V1 pickup against mediators that don't handle batch delivery well. Credo-TS mediators need explicit V2 + batch pickup. This keeps the wallet code mediator-agnostic: set
MEDIATOR_URL+ flip the flag when pointing at Credo.Prod cutover (set staging/prod
MEDIATOR_URL, enable flag, smoke tests) tracked in #5.Test plan
MEDIATOR_USE_V2_BATCH_PICKUP=true+ Credo mediator → V2 live mode + batch pickup in logs