React Native 0.77 compatibility + E2E invitation hook#25
Closed
albertoleon7794 wants to merge 5 commits into
Closed
React Native 0.77 compatibility + E2E invitation hook#25albertoleon7794 wants to merge 5 commits into
albertoleon7794 wants to merge 5 commits into
Conversation
All jobs in main.yaml are commented out, causing instant failures on every push to main. Quality checks already run in quality.yaml; remove automatic push/PR triggers and keep the file as manual-only reference. Signed-off-by: Alberto L <aleon@law.harvard.edu>
DEV-only hidden text element publishes the OOB invitation URL to the accessibility tree so Appium can read it and paste it into the peer wallet (avoids camera-based QR scanning on emulators). Also show the paste-URL header button in camera-scan mode so the flow is reachable without tabs. Signed-off-by: Alberto L <aleon@law.harvard.edu>
- Replace removed BackHandler.removeEventListener with the addEventListener subscription's remove() (RN 0.77 API) in Onboarding, ProofDetails and ProofRequesting. - Loosen react-native ecosystem peerDependencies (gesture-handler, safe-area-context, screens, svg) to >= ranges so core can be consumed by apps on newer RN; devDependencies stay pinned. - Kotlin 2.0 null-safety fix in react-native-attestation certificate chain parsing. - Commit QRScanner snapshot for the E2E InvitationUrl test hook (missed in the previous commit). Signed-off-by: Alberto L <aleon@law.harvard.edu>
…gression With react-native 0.77 / safe-area-context 5.x, a ScrollView styled with height:'100%' inside a SafeAreaView that lacks flex:1 grows past the screen and pushes the controls container (marginTop:'auto') out of view, making Continue/Done buttons unreachable on both platforms. Apply flex:1 to the SafeAreaView wrapper and the ScrollView in the affected modal-style screens: CredentialOfferAccept, ProofRequestAccept, CameraDisclosureModal, MobileVerifierLoading, CommonRemoveModal. Snapshots updated accordingly; also check in the regenerated react-native-attestation gradle lockfile. Signed-off-by: Alberto L <aleon@law.harvard.edu>
The RN 0.77 compatibility commit widened @bifold/core peerDependencies (react-native-gesture-handler, react-native-safe-area-context, react-native-screens, react-native-svg from ~x.y.z to >=x.y.z) but did not regenerate the lockfile, so `yarn install --immutable` fails in CI with YN0028. Signed-off-by: Alberto L <aleon@law.harvard.edu>
Collaborator
Author
|
Superseded by the consolidated upgrade PR #31, which folds the bifold 3.x / credo-ts 0.6 upgrade and the eddsa-rdfc-2022 Data Integrity work into a single review branch. Closing without merge — see the consolidated PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to berkmancenter/keyring-wallet#13 (upgrade Phases 1+2 — tracked in berkmancenter/keyring-wallet#8 and #9). Three commits:
1718d331— expose the invitation URL and a paste-URL fallback on the Scan screen (dev/E2E only) so the Appium two-wallet VRC exchange can run on emulators without camera-to-camera QR scanning.363b325a— compatibility fixes for React Native 0.77 host apps: BackHandler subscription API, Kotlin 2.0 null-safety in react-native-attestation, and related build updates.e94c45b2— fix the RN 0.77 / safe-area-context 5.x layout regression that pushed bottom controls (Done/Continue) off-screen in CredentialOfferAccept, ProofRequestAccept, CameraDisclosureModal, MobileVerifierLoading, and CommonRemoveModal.The keyring-wallet
upgrade/phase2-rn77branch pins its submodule to the head of this branch.Note: Phase 3 (berkmancenter/keyring-wallet#10) will rebuild this fork from upstream bifold-wallet v3.0.16 content, so this PR mainly preserves the reviewable record of the RN 0.77 work; the changes will be re-ported as part of the Phase 3 delta.
Test plan
Made with Cursor