Skip to content

fix(ui): keep unread badges, mention toggles, and pending switches across a channel rename #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lafnaps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): keep unread badges, mention toggles, and pending switches across a channel rename #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions static/chat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,23 @@ function connectWebSocket() {
});
_showNextPendingName();
} else if (event.type === 'channel_renamed') {
// Migrate per-channel client state to the new name
const channelIndex = channelList.indexOf(event.old_name);
if (channelIndex !== -1) {
channelList = [...channelList];
channelList[channelIndex] = event.new_name;
}
if (channelUnread[event.old_name] !== undefined) {
channelUnread[event.new_name] = channelUnread[event.old_name];
delete channelUnread[event.old_name];
}
if (_channelMentions[event.old_name] !== undefined) {
_channelMentions[event.new_name] = _channelMentions[event.old_name];
delete _channelMentions[event.old_name];
}
if (pendingChannelSwitch === event.old_name) {
pendingChannelSwitch = event.new_name;
}
// Migrate data-channel on existing DOM elements
const container = document.getElementById('messages');
for (const el of container.children) {
Expand All @@ -545,6 +562,8 @@ function connectWebSocket() {
localStorage.setItem('agentchattr-channel', event.new_name);
Store.set('activeChannel', event.new_name);
}
filterMessagesByChannel();
renderChannelTabs();
} else if (event.type === 'edit') {
// A message was edited/demoted — re-render it in place
const updatedMsg = event.message;
Expand Down
2 changes: 1 addition & 1 deletion static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,6 @@ <h1 id="room-title">agentchattr</h1>
<script src="/static/jobs.js?v=224"></script>
<script src="/static/channels.js?v=225"></script>
<script src="/static/rules-panel.js?v=223"></script>
<script src="/static/chat.js?v=268"></script>
<script src="/static/chat.js?v=269"></script>
</body>
</html>