Skip to content

chore(ci): adopt upstream semantic-pull-request and sticky comments - #2841

Merged
DerekRoberts merged 6 commits into
mainfrom
chore/migrate-to-upstream-actions-and-sticky-comments
Sep 9, 2026
Merged

DerekRoberts merged 6 commits into
mainfrom
chore/migrate-to-upstream-actions-and-sticky-comments

Conversation

@DerekRoberts

@DerekRoberts DerekRoberts commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

Summary

Migrates quickstart-openshift templates to direct upstream actions for PR validation and deployment link notifications:

  1. Calls amannn/action-semantic-pull-request directly in pr-validate.yml under the job name Validate Results, eliminating the redundant downstream aggregator job while preserving naming symmetry (Analysis Results, PR Results, Validate Results). Scopes permissions down to pull-requests: read.
  2. Adopts sticky PR comments via marocchino/sticky-pull-request-comment in pr-open.yml (posted after deployment succeeds) and removes unnecessary comment cleanup on PR close.

Changes

  • .github/workflows/pr-validate.yml: Migrated validate job to directly invoke amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 (v6.1.1) named Validate Results. Dropped separate redundant aggregator job.
  • .github/workflows/pr-open.yml: Added comment job using marocchino/sticky-pull-request-comment@5770ad5eb8f42dd2c4f34da00c94c5381e49af88 (v3.0.5) to post sticky deployment links when deployments trigger. Added comment to results.needs.
  • .github/workflows/pr-close.yml: Removed redundant comment cleanup job and dropped pull-requests: write permissions.
  • README.md: Updated workflow documentation descriptions and required status checks list.

Closes bcgov/actions#198

Update pr-validate.yml to call amannn/action-semantic-pull-request directly instead of passing markdown_links to legacy helper. Update pr-open.yml to post deployment links via marocchino/sticky-pull-request-comment and pr-close.yml to clean them up. Update README.md workflow descriptions.

Closes bcgov/actions#198
Copilot AI balanced review requested due to automatic review settings September 8, 2026 23:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The pinned actions, permissions, job dependencies, and documentation consistently implement the stated migration.

Pull request overview

Migrates PR validation and deployment notifications to pinned upstream GitHub Actions, supporting bcgov/actions#198.

Changes:

  • Directly validates semantic PR titles.
  • Posts and removes sticky deployment-link comments.
  • Updates workflow documentation.
File summaries
File Description
README.md Documents revised workflow behavior.
.github/workflows/pr-validate.yml Uses upstream semantic-title validation.
.github/workflows/pr-open.yml Posts deployment links after deployment.
.github/workflows/pr-close.yml Deletes deployment-link comments on closure.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Deployments Available

@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Sep 9, 2026
@DerekRoberts DerekRoberts self-assigned this Sep 9, 2026
Drop the comment job and pull-requests: write permission from pr-close.yml. Update README.md to remove the redundant cleanup description.
@DerekRoberts DerekRoberts changed the title chore: adopt upstream semantic-pull-request and sticky comments chore(ci): adopt upstream semantic-pull-request and sticky comments Sep 9, 2026
@DerekRoberts
DerekRoberts merged commit 772763a into main Sep 9, 2026
22 checks passed
@DerekRoberts
DerekRoberts deleted the chore/migrate-to-upstream-actions-and-sticky-comments branch September 9, 2026 01:49
@github-project-automation github-project-automation Bot moved this from Active to Done in DevOps (NR) Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

chore: remove pr-validate and pr-description-add in favor of direct upstream actions

2 participants